Closed
Bug 1737093
Opened 4 years ago
Closed 4 years ago
SanitizeRenderer.cpp: the 'empty' method should be used to check for emptiness instead of 'size'
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox96 fixed)
RESOLVED
FIXED
96 Branch
| Tracking | Status | |
|---|---|---|
| firefox96 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: vishal.vikal.88, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 file, 2 obsolete files)
Filling as a good first bug to learn workflows.
if (!m.str(1).size()) {
should use .empty() instead
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-container-size-empty.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
Reporter | |
Updated•4 years ago
|
Mentor: sledru
|
|
Reporter | |
Updated•4 years ago
|
Keywords: good-first-bug
Whiteboard: [lang=C++]
|
||
Updated•4 years ago
|
Assignee: nobody → vishal.vikal.88
Status: NEW → ASSIGNED
|
|
||
Updated•4 years ago
|
Attachment #9248491 -
Attachment is obsolete: true
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b74f07eabdba
use empty instead of size r=sylvestre
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox96:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch
|
|
||
Updated•4 years ago
|
Attachment #9249611 -
Attachment is obsolete: true
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•